Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds known #585

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Adds known #585

merged 1 commit into from
Dec 7, 2016

Conversation

pierreozoux
Copy link
Contributor

No description provided.

@pierreozoux pierreozoux mentioned this pull request May 22, 2016
Merged
9 tasks
@pierreozoux pierreozoux force-pushed the known branch 2 times, most recently from e784118 to d3c6a23 Compare May 22, 2016 10:06
@pierreozoux pierreozoux force-pushed the known branch 2 times, most recently from be9cb8a to f793ad9 Compare August 10, 2016 10:45
tianon
tianon approved these changes Nov 30, 2016
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks fine to me!

known/content.md
@@ -0,0 +1,50 @@
#Known: social publishing for groups and individuals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ought to have a space between # and Known

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think doing git pull --rebase https://github.com/docker-library/docs.git master would probably get Travis cleared/green. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Followed by a force push, of course.)

@pierreozoux
Copy link
Contributor Author

@tianon good catch, just fixed ;)

@pierreozoux
Copy link
Contributor Author

Just did a rebase, and all green :)

@yosifkit yosifkit merged commit 5f09885 into docker-library:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

@tianon tianon tianon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierreozoux @tianon @yosifkit